Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_managed_disk - add log and remove feature flag in state migration #18993

Merged
merged 2 commits into from
Oct 26, 2022
Merged

azurerm_managed_disk - add log and remove feature flag in state migration #18993

merged 2 commits into from
Oct 26, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Oct 26, 2022

stephybun
stephybun requested changes Oct 26, 2022
View reviewed changes
internal/services/compute/migration/managed_disk_v0_to_v1.go
@@ -197,7 +201,7 @@ func (ManagedDiskV0ToV1) Schema() map[string]*pluginsdk.Schema {
}
}

func encryptionSettingsSchema() *pluginsdk.Schema {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this in the initial PR, but since this is a point in time reference we need to remove the schema feature flag and the Schema for 4.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense. I've removed the feature flag and kept only the 3.0 schema for this

@myc2h6o myc2h6o mentioned this pull request Oct 26, 2022
Merged
@myc2h6o myc2h6o changed the title azurerm_managed_disk - add log to state migration and update schema function name azurerm_managed_disk - add log and remove feature flag in state migration Oct 26, 2022
stephybun
stephybun approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o LGTM 👍

@stephybun stephybun merged commit 85bc991 into hashicorp:main Oct 26, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 26, 2022
@myc2h6o myc2h6o deleted the disk_migration branch October 26, 2022 14:24
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
enhancement service/disks
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@myc2h6o @stephybun